[GitHub][CI] Add missing dependencies to code-lint container #163873

vbvictor · 2025-10-16T21:50:13Z

No description provided.

llvmbot · 2025-10-16T21:50:56Z

@llvm/pr-subscribers-github-workflow

Author: Baranov Victor (vbvictor)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/163873.diff

1 Files Affected:

(modified) .github/workflows/containers/github-action-ci-tooling/Dockerfile (+18-1)

diff --git a/.github/workflows/containers/github-action-ci-tooling/Dockerfile b/.github/workflows/containers/github-action-ci-tooling/Dockerfile
index 7d64562876628..5e13455d70123 100644
--- a/.github/workflows/containers/github-action-ci-tooling/Dockerfile
+++ b/.github/workflows/containers/github-action-ci-tooling/Dockerfile
@@ -9,6 +9,8 @@ RUN apt-get update && \
     mkdir -p /llvm-extract && \
     tar -xvJf llvm.tar.xz -C /llvm-extract \
         # Only unpack these tools to save space on Github runner.
+        LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-${LLVM_VERSION%%.*} \
+        LLVM-${LLVM_VERSION}-Linux-X64/lib/clang/${LLVM_VERSION%%.*}/include \
         LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-tidy \
         LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-format \
         LLVM-${LLVM_VERSION}-Linux-X64/bin/git-clang-format && \
@@ -51,11 +53,26 @@ RUN pip install -r requirements_formatting.txt --break-system-packages && \
 FROM base AS ci-container-code-lint
 ARG LLVM_VERSION
 
-COPY --from=llvm-downloader /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-tidy ${LLVM_SYSROOT}/bin/
+COPY --from=llvm-downloader /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-tidy \
+                            /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-${LLVM_VERSION%%.*} \
+                            ${LLVM_SYSROOT}/bin/
+COPY --from=llvm-downloader /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/lib/clang/${LLVM_VERSION%%.*}/include \
+                            ${LLVM_SYSROOT}/lib/clang/${LLVM_VERSION%%.*}/include
 COPY clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py ${LLVM_SYSROOT}/bin/clang-tidy-diff.py
 
+# Make symlinks as in LLVM tar.xz package
+RUN ln -s ${LLVM_SYSROOT}/bin/clang-${LLVM_VERSION%%.*} ${LLVM_SYSROOT}/bin/clang && \
+    ln -s ${LLVM_SYSROOT}/bin/clang ${LLVM_SYSROOT}/bin/clang++
+
 ENV PATH=${LLVM_SYSROOT}/bin:${PATH}
 
+RUN apt-get update && \
+    DEBIAN_FRONTEND=noninteractive apt-get install -y \
+    cmake \
+    ninja-build && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*
+
 # Install dependencies for 'pr-code-lint.yml' job
 COPY llvm/utils/git/requirements_linting.txt requirements_linting.txt
 RUN pip install -r requirements_linting.txt --break-system-packages && \

vbvictor · 2025-10-16T21:51:28Z

.github/workflows/containers/github-action-ci-tooling/Dockerfile

+        LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-${LLVM_VERSION%%.*} \
+        LLVM-${LLVM_VERSION}-Linux-X64/lib/clang/${LLVM_VERSION%%.*}/include \


I'm installing clang "manually" together with built-in libs that are needed for clang-tidy invocation.

boomanaiden154

Have you tested that you can run clang-tidy in the container with these changes?

vbvictor · 2025-10-16T22:01:37Z

Have you tested that you can run clang-tidy in the container with these changes?

Yes, I've checked that I can configure,build,run clang-tidy-diff.py inside container

vbvictor · 2025-10-16T22:26:32Z

I can't reproduce podman build error locally

Error: resolving step {Value:copy Next:0xc000266310 Children:[] Attributes:map[] Original:COPY --from=llvm-downloader /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-tidy                             /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-${LLVM_VERSION%%.*}                             ${LLVM_SYSROOT}/bin/ Flags:[--from=llvm-downloader] StartLine:56 EndLine:58}: Missing ':' in substitution: /llvm-extract/LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-${LLVM_VERSION%%.*}

So I use separate ARG variable for major LLVM version

boomanaiden154 · 2025-10-16T23:28:43Z

.github/workflows/containers/github-action-ci-tooling/Dockerfile

@@ -1,14 +1,18 @@
 ARG LLVM_VERSION=21.1.0
+ARG LLVM_VERSION_MAJOR=21


I would prefer if we put a little bit more effort into trying to consolidate these. There's almost certainly a way to get it working.

Is the local/Github difference maybe related to podman versions?

This syntax is supported in docker/buildkit stack but I couldn't find that it is supported in podman/buildah stack. Locally I have Buildah 1.39 and in CI it's 1.33. I checked https://buildah.io/releases/ but nothing mentioned "variable expansions" in release notes from 1.33 to 1.39, so I have generally no idea how it works locally.

Oh I found openshift/imagebuilder@88c69f9 (available in v1.2.12 or more) which adds support for %% syntax.

https://buildah.io/releases/#changes-for-v1370 bumped imagebuilder version to v1.2.14 which supports %% and other shell syntax. So we essentially need to have Buildah 1.37 instead of 1.33 in CI (Ubuntu 24.04).

So I think we can use LLVM_VERSION_MAJOR and leave a TODO for Ubuntu-26.04 runners, which should have higher version of Buildah (Ubuntu-25.04 has 1.39).

Another option is to move to docker buildx but I don't think we want it.

Ack. I'm fine leaving a TODO for ~6 months given we have an understanding of what the issue is, which we do now. Nice investigation.

.github/workflows/containers/github-action-ci-tooling/Dockerfile

vbvictor requested a review from boomanaiden154 October 16, 2025 21:50

llvmbot added the github:workflow label Oct 16, 2025

vbvictor commented Oct 16, 2025

View reviewed changes

boomanaiden154 reviewed Oct 16, 2025

View reviewed changes

vbvictor force-pushed the add-clang-tidy-native-runner branch from 9ba0e5d to 4dd94be Compare October 17, 2025 21:59

[GitHub][CI] Add missing dependencies to code-lint container

27c773e

vbvictor force-pushed the add-clang-tidy-native-runner branch from 4dd94be to 27c773e Compare October 19, 2025 10:35

vbvictor requested a review from boomanaiden154 October 19, 2025 11:24

vbvictor commented Oct 19, 2025

View reviewed changes

.github/workflows/containers/github-action-ci-tooling/Dockerfile Outdated Show resolved Hide resolved

Update .github/workflows/containers/github-action-ci-tooling/Dockerfile

b7530b0

boomanaiden154 approved these changes Oct 19, 2025

View reviewed changes

vbvictor merged commit e4c97f0 into llvm:main Oct 19, 2025
14 checks passed

		LLVM-${LLVM_VERSION}-Linux-X64/bin/clang-${LLVM_VERSION%%.*} \
		LLVM-${LLVM_VERSION}-Linux-X64/lib/clang/${LLVM_VERSION%%.*}/include \

		@@ -1,14 +1,18 @@
		ARG LLVM_VERSION=21.1.0
		ARG LLVM_VERSION_MAJOR=21

[GitHub][CI] Add missing dependencies to code-lint container #163873

[GitHub][CI] Add missing dependencies to code-lint container #163873

Uh oh!

Conversation

vbvictor commented Oct 16, 2025

Uh oh!

llvmbot commented Oct 16, 2025

Uh oh!

vbvictor Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

boomanaiden154 left a comment

Choose a reason for hiding this comment

Uh oh!

vbvictor commented Oct 16, 2025

Uh oh!

vbvictor commented Oct 16, 2025

Uh oh!

boomanaiden154 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

vbvictor Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

vbvictor Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbvictor Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbvictor Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boomanaiden154 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vbvictor Oct 17, 2025 •

edited

Loading

vbvictor Oct 17, 2025 •

edited

Loading

vbvictor Oct 18, 2025 •

edited

Loading